codings-dan commented on code in PR #658:
URL: https://github.com/apache/ratis/pull/658#discussion_r905056898
##########
ratis-client/src/main/java/org/apache/ratis/client/api/AdminApi.java:
##########
@@ -41,10 +42,16 @@ default RaftClientReply setConfiguration(RaftPeer[]
serversInNewConf) throws IOE
return setConfiguration(Arrays.asList(serversInNewConf));
}
+ RaftClientReply setConfiguration(List<RaftPeer> serversInNewConf,
SetConfigurationRequest.Mode mode)
+ throws IOException;
+
/** Set the configuration request to the raft service. */
RaftClientReply setConfiguration(List<RaftPeer> serversInNewConf,
List<RaftPeer> listenersInNewConf)
throws IOException;
+ RaftClientReply setConfiguration(List<RaftPeer> serversInNewConf,
List<RaftPeer> listenersInNewConf,
+ SetConfigurationRequest.Mode mode) throws IOException;
+
Review Comment:
Good catch, I have refactored this part of the interface related code,
please take a look, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
