ChenSammi commented on code in PR #561:
URL: https://github.com/apache/ratis/pull/561#discussion_r911679935
##########
ratis-common/src/main/java/org/apache/ratis/util/LifeCycle.java:
##########
@@ -100,8 +100,8 @@ static void put(State key, Map<State, List<State>> map,
State... values) {
put(PAUSING, predecessors, RUNNING);
put(PAUSED, predecessors, PAUSING);
put(EXCEPTION, predecessors, STARTING, PAUSING, RUNNING);
- put(CLOSING, predecessors, STARTING, RUNNING, PAUSING, PAUSED,
EXCEPTION);
- put(CLOSED, predecessors, NEW, CLOSING);
+ put(CLOSING, predecessors, NEW, STARTING, RUNNING, PAUSING, PAUSED,
EXCEPTION);
+ put(CLOSED, predecessors, CLOSING);
Review Comment:
There is one hidden issue if we move the NettyRpcService build to startImpl,
getInetSocketAddress is called before startImpl. getInetSocketAddress will
try to get the server port. The default configured port is 0. So if server is
not started, we cannot know the actual port of this server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
