lanicc commented on PR #672: URL: https://github.com/apache/ratis/pull/672#issuecomment-1177158037
Grpcservice also has this problem. Its constructor contains too many parameters so that I do not have a good idea to fix it. Does anyone have a good idea https://github.com/apache/ratis/blob/c320f93c5a510f07933536e28e507ef9c3ba3531/ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcService.java#L133 ``` @SuppressWarnings("checkstyle:ParameterNumber") // private constructor private GrpcService(RaftServer raftServer, Supplier<RaftPeerId> idSupplier, int adminPort, GrpcTlsConfig adminTlsConfig, int clientPort, GrpcTlsConfig clientTlsConfig, int serverPort, GrpcTlsConfig serverTlsConfig, SizeInBytes grpcMessageSizeMax, SizeInBytes appenderBufferSize, SizeInBytes flowControlWindow,TimeDuration requestTimeoutDuration) { ... } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
