[
https://issues.apache.org/jira/browse/RATIS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563825#comment-17563825
]
Zili Chen commented on RATIS-121:
---------------------------------
[~szetszwo] reading the related code today, I wonder whether random generate
serverId only valid if group is also empty? I can hardly imagine a server with
initial group but without serverId that is part of the group.
If we should hold the condition that if group is set, serverId should be
non-null and a member of group peers, we should validate it when construct the
server (in the builder or the constructor). I trying to remove serverId part
from Counter example and the client hangs.
> In RaftServer.Builder, allow serverId and group to be initialized
> automatically
> -------------------------------------------------------------------------------
>
> Key: RATIS-121
> URL: https://issues.apache.org/jira/browse/RATIS-121
> Project: Ratis
> Issue Type: Improvement
> Reporter: Tsz-wo Sze
> Assignee: Tsz-wo Sze
> Priority: Major
> Fix For: 0.2.0
>
> Attachments: r121_20171013.patch
>
>
> When the serverId is missing, it can be initialized automatically using the
> given properties such as host and port.
> Also, the group should be automatically initialized to an empty group since
> group may not be known when starting a server.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
