szetszwo commented on code in PR #673:
URL: https://github.com/apache/ratis/pull/673#discussion_r916148743
##########
ratis-common/src/main/java/org/apache/ratis/protocol/RaftGroup.java:
##########
@@ -43,17 +43,28 @@ public static RaftGroup valueOf(RaftGroupId groupId,
Collection<RaftPeer> peers)
return new RaftGroup(groupId, peers);
}
+ public static RaftGroup valueOf(RaftGroupId groupId, Collection<RaftPeer>
peers,
+ Collection<RaftPeer> listeners) {
+ return new RaftGroup(groupId, peers, listeners);
+ }
+
/** The group id */
private final RaftGroupId groupId;
/** The group of raft peers */
private final Map<RaftPeerId, RaftPeer> peers;
+ private final Map<RaftPeerId, RaftPeer> listeners;
Review Comment:
@qian0817 , thanks a lot for working on this. Let's add a startupRole in
RaftPeer instead of change RaftGroup.
```
//RaftPeer
private final RaftPeerRole startupRole;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
