adoroszlai commented on code in PR #702:
URL: https://github.com/apache/ratis/pull/702#discussion_r937094874
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java:
##########
@@ -1413,7 +1413,7 @@ leaderId, getMemberId(), currentTerm, followerCommit,
state.getNextIndex(), NOT_
getRaftServer().getPeer());
}
}
- return JavaUtils.allOf(futures).whenCompleteAsync(
+ return JavaUtils.allOf(futures).whenComplete(
Review Comment:
Thanks @szetszwo for the review. [Passing `serverExecutor` was my first
attempt](https://github.com/adoroszlai/incubator-ratis/commit/601fb05cb6a32ba380e0782c9d8fe17b1651de43),
but it caused [timeout in
`TestInstallSnapshotNotificationWithGrpc`](https://github.com/adoroszlai/incubator-ratis/runs/7650650577?check_suite_focus=true#step:5:2830).
It may indicate that the test or some other part of Ratis needs further
tweak. I'll take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
