[
https://issues.apache.org/jira/browse/RATIS-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz-wo Sze updated RATIS-1656:
------------------------------
Fix Version/s: 2.4.0
> Leftover usage of ForkJoinPool.commonPool() in RaftServerImpl
> -------------------------------------------------------------
>
> Key: RATIS-1656
> URL: https://issues.apache.org/jira/browse/RATIS-1656
> Project: Ratis
> Issue Type: Improvement
> Components: server
> Affects Versions: 2.3.0
> Reporter: Attila Doroszlai
> Assignee: Attila Doroszlai
> Priority: Minor
> Fix For: 2.4.0, 3.0.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> {{RaftServerImpl#appendEntriesAsync}} is still using the common pool here:
> {code:title=https://github.com/apache/ratis/blob/3db8f9eac82efedd51322a0d213300c9a0940bb6/ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java#L1416-L1417}
> return JavaUtils.allOf(futures).whenCompleteAsync(
> (r, t) -> followerState.ifPresent(fs ->
> fs.updateLastRpcTime(FollowerState.UpdateType.APPEND_COMPLETE))
> {code}
> I think it should be executed directly, since it's already executing on
> {{serverExecutor}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
