szetszwo commented on code in PR #713:
URL: https://github.com/apache/ratis/pull/713#discussion_r949389163
##########
ratis-server-api/src/main/java/org/apache/ratis/server/RaftServerConfigKeys.java:
##########
@@ -608,24 +608,54 @@ interface Rpc {
String TIMEOUT_MIN_KEY = PREFIX + ".timeout.min";
TimeDuration TIMEOUT_MIN_DEFAULT = TimeDuration.valueOf(150,
TimeUnit.MILLISECONDS);
- static TimeDuration timeoutMin(RaftProperties properties) {
+ static TimeDuration timeoutMin(RaftProperties properties, Consumer<String>
logger) {
return
getTimeDuration(properties.getTimeDuration(TIMEOUT_MIN_DEFAULT.getUnit()),
- TIMEOUT_MIN_KEY, TIMEOUT_MIN_DEFAULT, getDefaultLog());
+ TIMEOUT_MIN_KEY, TIMEOUT_MIN_DEFAULT, logger);
+ }
+ static TimeDuration timeoutMin(RaftProperties properties) {
+ return timeoutMin(properties, getDefaultLog());
}
static void setTimeoutMin(RaftProperties properties, TimeDuration
minDuration) {
setTimeDuration(properties::setTimeDuration, TIMEOUT_MIN_KEY,
minDuration);
}
String TIMEOUT_MAX_KEY = PREFIX + ".timeout.max";
TimeDuration TIMEOUT_MAX_DEFAULT = TimeDuration.valueOf(300,
TimeUnit.MILLISECONDS);
- static TimeDuration timeoutMax(RaftProperties properties) {
+ static TimeDuration timeoutMax(RaftProperties properties, Consumer<String>
logger) {
return
getTimeDuration(properties.getTimeDuration(TIMEOUT_MAX_DEFAULT.getUnit()),
- TIMEOUT_MAX_KEY, TIMEOUT_MAX_DEFAULT, getDefaultLog());
+ TIMEOUT_MAX_KEY, TIMEOUT_MAX_DEFAULT, logger);
+ }
+ static TimeDuration timeoutMax(RaftProperties properties) {
+ return timeoutMax(properties, getDefaultLog());
}
static void setTimeoutMax(RaftProperties properties, TimeDuration
maxDuration) {
setTimeDuration(properties::setTimeDuration, TIMEOUT_MAX_KEY,
maxDuration);
}
+ /** separate first timeout so that the startup unavailable time can be
reduced */
+ String FIRST_ELECTION_TIMEOUT_MIN_KEY = PREFIX +
".first-election.timeout.min";
+ TimeDuration FIRST_ELECTION_TIMEOUT_MIN_DEFAULT = null;
+ static TimeDuration firstElectionTimeoutMin(RaftProperties properties) {
+ final TimeDuration fallbackFirstElectionTimeoutMin =
Rpc.timeoutMin(properties, null);
+ return
getTimeDuration(properties.getTimeDuration(fallbackFirstElectionTimeoutMin.getUnit()),
+ FIRST_ELECTION_TIMEOUT_MIN_KEY, FIRST_ELECTION_TIMEOUT_MIN_DEFAULT,
+ Rpc.TIMEOUT_MIN_KEY, fallbackFirstElectionTimeoutMin,
getDefaultLog());
+ }
+ static void setFirstElectionTimeoutMin(RaftProperties properties,
TimeDuration firstMinDuration) {
+ setTimeDuration(properties::setTimeDuration,
FIRST_ELECTION_TIMEOUT_MIN_KEY, firstMinDuration);
+ }
+
+ String FIRST_ELECTION_TIMEOUT_MAX_KEY = PREFIX +
".first-election.timeout.max";
+ TimeDuration FIRST_ELECTION_TIMEOUT_MAX_DEFAULT = null;
+ static TimeDuration firstElectionTimeoutMax(RaftProperties properties) {
+ final TimeDuration fallbackFirstElectionTimeoutMax =
Rpc.timeoutMax(properties, null);
+ return
getTimeDuration(properties.getTimeDuration(fallbackFirstElectionTimeoutMax.getUnit()),
+ FIRST_ELECTION_TIMEOUT_MAX_KEY, fallbackFirstElectionTimeoutMax,
getDefaultLog());
Review Comment:
It should use the fallback method and in the min.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
