SzyWilliam commented on PR #730: URL: https://github.com/apache/ratis/pull/730#issuecomment-1231765653
@szetszwo Thanks for the review! I've made changes on code. Maybe we can move AppendEntriesListener and its navigable map to LeaderStateImpl, as 1. AppendEntriesListener is only valid and be called when peer is in valid leadership. 2. AppendEntriesListener map should have the same lifecycle with LeaderState. Remaining pending listeners in map should be cleared when leader steps down, and the map should be recreated empty when peer is reelected as leader again. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
