codings-dan commented on PR #749: URL: https://github.com/apache/ratis/pull/749#issuecomment-1254780575
> @codings-dan , thanks a lot for reviewing this! > > > BTW, should we just remove the ratis-metrics module directly? > > Do you mean we should not rename `ratis-metrics` to `ratis-metrics-api` and keep using the name `ratis-metrics`? I thought about it -- since the API has changed, it probably will have more confusion if we keep using `ratis-metrics`. The applications has to update the code anyway. Using also the module name is not a big deal. Change the name is fine. I mean, since the `ratis-metrics` module is empty now, shouldn't we just remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
