szetszwo commented on PR #751: URL: https://github.com/apache/ratis/pull/751#issuecomment-1258231915
@codings-dan , thanks a lot for reviewing this! > ... most of the code in the ratis-metrics-default and ratis-metrics-dropwizard3 modules is duplicated, is there some way we can reduce these duplication of code? The code does look the same but the underlying classes are different (dropwizard3 vs the shaded dropwizard4). Unfortunately, there is no easy way to share the code since we cannot make the classes in dropwizard3 and dropwizard4 implementing a common interface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
