codings-dan commented on code in PR #817:
URL: https://github.com/apache/ratis/pull/817#discussion_r1093328275
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/ReadIndexHeartbeats.java:
##########
@@ -110,6 +111,10 @@ boolean receive(LogAppender logAppender,
AppendEntriesReplyProto proto,
return isCompletedNormally();
}
+ boolean isAcknowledged(RaftPeerId id) {
+ return
Optional.ofNullable(replies.get(id)).map(HeartbeatAck::isAcknowledged).isPresent();
Review Comment:
Thanks for helping review the pull request! The current changes have
introduced new problems and your two changes are correct. Let me revert this
and then submit a new pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
