szetszwo commented on code in PR #837:
URL: https://github.com/apache/ratis/pull/837#discussion_r1122269762


##########
ratis-test/src/test/java/org/apache/ratis/grpc/TestLogAppenderWithGrpc.java:
##########
@@ -89,7 +89,7 @@ public void testPendingLimits() throws IOException, 
InterruptedException {
         futures.add(client.async().send(new RaftTestUtil.SimpleMessage("m")));
       }
 
-      FIVE_SECONDS.sleep();
+      TEN_SECONDS.sleep();

Review Comment:
   @AngersZhuuuu , thanks a lot for fixing this.  Let's use `JavaUtils.attempt` 
to retry.
   ```java
         JavaUtils.attempt(() -> {
               for (long nextIndex : leader.getInfo().getFollowerNextIndices()) 
{
                 // Verify nextIndex does not progress due to pendingRequests 
limit
                 Assert.assertEquals(initialNextIndex + maxAppends, nextIndex);
               }
             }, 5, ONE_SECOND, "matching nextIndex", LOG);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to