AngersZhuuuu commented on code in PR #836:
URL: https://github.com/apache/ratis/pull/836#discussion_r1122532080
##########
ratis-shell/src/main/libexec/ratis-shell-config.sh:
##########
@@ -75,7 +75,7 @@ if [[ -n "${RATIS_SHELL_HOME}" ]]; then
RATIS_SHELL_JAVA_OPTS+=" -Dratis.shell.home=${RATIS_SHELL_HOME}"
fi
-RATIS_SHELL_JAVA_OPTS+=" -Dratis.shell.conf.dir=${RATIS_SHELL_CONF_DIR}
-Dratis.shell.logs.dir=${RATIS_SHELL_LOGS_DIR}
-Dratis.shell.user.logs.dir=${RATIS_SHELL_USER_LOGS_DIR}"
+RATIS_SHELL_JAVA_OPTS+=" -Dratis.shell.conf.dir=${RATIS_SHELL_CONF_DIR}
-Dratis.shell.logs.dir=${RATIS_SHELL_LOGS_DIR}"
Review Comment:
Yea, not need too, also I remove
```
-if [[ -n "${RATIS_SHELL_HOME}" ]]; then
RATIS_SHELL_JAVA_OPTS+=" -Dratis.shell.home=${RATIS_SHELL_HOME}"
fi
```
By the way, RATIS_SHELL_ASSEMBLY_CLIENT_JAR really necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
