szetszwo commented on code in PR #847:
URL: https://github.com/apache/ratis/pull/847#discussion_r1130244158
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java:
##########
@@ -890,15 +890,14 @@ public CompletableFuture<RaftClientReply>
submitClientRequestAsync(
}
final RaftClientRequest.Type type = request.getType();
- replyFuture.whenComplete((clientReply, exception) -> {
+ return replyFuture.whenComplete((clientReply, exception) -> {
if (clientReply.isSuccess()) {
Review Comment:
BTW, it should stop the timer even if it has failed. Could you also change
it?
```java
- if (clientReply.isSuccess()) {
- timerContext.ifPresent(Timekeeper.Context::stop);
- }
+ timerContext.ifPresent(Timekeeper.Context::stop);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
