szetszwo commented on code in PR #852:
URL: https://github.com/apache/ratis/pull/852#discussion_r1133678371
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java:
##########
@@ -580,7 +582,11 @@ public Collection<CommitInfoProto> getCommitInfos() {
role.getLeaderState().ifPresent(
leader -> leader.updateFollowerCommitInfos(commitInfoCache, infos));
} else {
- getRaftConf().getAllPeers().stream()
+ StreamSupport.stream(
+ Iterables
Review Comment:
@qian0817 , thanks a lot for working on this!
Let's use `Stream.concat` and also the same conf (otherwise, it could be
changed.)
```java
final RaftConfigurationImpl conf = getRaftConf();
Stream.concat(conf.getAllPeers().stream(),
conf.getAllPeers(RaftPeerRole.LISTENER).stream())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
