kaijchen commented on code in PR #855:
URL: https://github.com/apache/ratis/pull/855#discussion_r1137073321
##########
ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/SegmentedRaftLog.java:
##########
@@ -414,7 +414,7 @@ protected CompletableFuture<Long>
appendEntryImpl(LogEntryProto entry) {
} else {
cache.appendEntry(entry,
LogSegment.Op.WRITE_CACHE_WITHOUT_STATE_MACHINE_CACHE);
}
- return writeFuture;
+ return writeFuture.whenComplete((clientReply, exception) ->
appendEntryTimerContext.stop());
Review Comment:
I'm OK with both. I was wondering which style is preferred.
Just a week ago, we chose the async one here:
https://github.com/apache/ratis/pull/847#pullrequestreview-1331830501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
