szetszwo commented on code in PR #854: URL: https://github.com/apache/ratis/pull/854#discussion_r1141319588
########## dev-support/find-mvn.sh: ########## @@ -0,0 +1,24 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +function find_mvn() { + local DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" + ( cd "$DIR/.." || exit 1 ; echo "$( pwd -P )/mvnw" ) +} + +export MVN="$( find_mvn )" Review Comment: Both DIR and MVN has the warning https://github.com/koalaman/shellcheck/wiki/SC2155 ########## dev-support/find-mvn.sh: ########## @@ -0,0 +1,24 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +function find_mvn() { Review Comment: Since we want to replace `mvn` with `${MVN}`, let's avoid using the string "mvn". Then, it is easier to search the missing changes. How about renaming it to "find_maven()"? Let also use the same name for the file, i.e. find_maven.sh BTW, there is a missing `mvn` change in `mvnFun()` in make_rc.sh . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
