guohao-rosicky commented on code in PR #884:
URL: https://github.com/apache/ratis/pull/884#discussion_r1221108120
##########
ratis-netty/src/main/java/org/apache/ratis/netty/server/DataStreamManagement.java:
##########
@@ -96,6 +96,10 @@ CompletableFuture<Long> write(ByteBuf buf,
Iterable<WriteOption> options,
n -> streamFuture.thenCompose(stream -> writeToAsync(buf, options,
stream, executor)
.whenComplete((l, e) -> metrics.stop(context, e == null))));
}
+
+ void cleanUp() {
+ streamFuture.thenAccept(DataStream::cleanUp);
+ }
Review Comment:
hi, @szetszwo
Whether the current implementation of ozone throws IOE if cleanUp is called
see:
https://github.com/apache/ozone/blob/master/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/LocalStream.java#L46
https://github.com/apache/ozone/blob/master/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/KeyValueStreamDataChannel.java#L246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
