[
https://issues.apache.org/jira/browse/RATIS-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17747816#comment-17747816
]
huxiangpeng commented on RATIS-1861:
------------------------------------
seems like :
{code:java}
// RaftServerImpl.java
synchronized void changeToLeader() {
Preconditions.assertTrue(getInfo().isCandidate());
role.shutdownLeaderElection();
setRole(RaftPeerRole.LEADER, "changeToLeader");
role.updateLeaderState(this);
state.becomeLeader();
// start sending AppendEntries RPC to followers
final LogEntryProto e = role.startLeaderState();
getState().setRaftConf(e);
}
// RoleInfo.java
void updateLeaderState(RaftServerImpl server) {
updateAndGet(leaderState, new LeaderStateImpl(server));
}
LogEntryProto startLeaderState() {
return leaderState.get().start();
}
{code}
> leaderState is updated after server becomes leader
> --------------------------------------------------
>
> Key: RATIS-1861
> URL: https://issues.apache.org/jira/browse/RATIS-1861
> Project: Ratis
> Issue Type: Bug
> Components: server
> Reporter: huxiangpeng
> Priority: Major
>
> Please see
> [code|https://github.com/apache/ratis/blob/master/ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java#L596-L605].
> When a server changes to leader, it will call the function
> [notifyLeaderChanged()|https://github.com/apache/ratis/blob/master/ratis-server/src/main/java/org/apache/ratis/server/impl/ServerState.java#L258]
> in becomeLeader().
> While leaderState is updated behind, so when notifyLeaderChanged() calls
> [readAsync()|https://github.com/apache/ratis/blob/master/ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java#L989]
> , it will cause the following NullPointerException.
>
> Caused by: java.lang.NullPointerException: 0: Server 0 not found: peers=[]
> at java.util.Objects.requireNonNull(Objects.java:290)
> at org.apache.ratis.util.PeerProxyMap.getProxy(PeerProxyMap.java:111)
> at
> org.apache.ratis.grpc.server.GrpcService$AsyncService.readIndexAsync(GrpcService.java:93)
> at
> org.apache.ratis.server.impl.RaftServerImpl.sendReadIndexAsync(RaftServerImpl.java:939)
> at
> org.apache.ratis.server.impl.RaftServerImpl.readAsync(RaftServerImpl.java:960)
> at
> org.apache.ratis.server.impl.RaftServerImpl.submitClientRequestAsync(RaftServerImpl.java:847)
> at
> org.apache.ratis.server.impl.RaftServerImpl.submitClientRequest(RaftServerImpl.java:1031)
> at
> org.apache.ratis.server.impl.RaftServerProxy.submitClientRequest(RaftServerProxy.java:449)
> at
> org.apache.iotdb.consensus.ratis.RatisConsensus.doRead(RatisConsensus.java:373)
> at
> org.apache.iotdb.consensus.ratis.RatisConsensus.read(RatisConsensus.java:339)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
