szetszwo commented on code in PR #896:
URL: https://github.com/apache/ratis/pull/896#discussion_r1277155562


##########
ratis-server-api/src/main/java/org/apache/ratis/server/RaftServerConfigKeys.java:
##########
@@ -586,6 +586,18 @@ static void setAutoTriggerEnabled(RaftProperties 
properties, boolean autoTrigger
       setBoolean(properties::setBoolean, AUTO_TRIGGER_ENABLED_KEY, 
autoTriggerEnabled);
     }
 
+    /** whether trigger snapshot when stop raft server */
+    String TRIGGER_SNAPSHOT_WHEN_STOP_ENABLED_KEY = PREFIX + 
".trigger.snapshot.when.stop.enabled";

Review Comment:
   Let's rename it to `PREFIX + ".trigger-when-stop.enabled"`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to