[
https://issues.apache.org/jira/browse/RATIS-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759145#comment-17759145
]
Tsz-wo Sze commented on RATIS-998:
----------------------------------
[~Sammi], yes, we should resolve this. The shouldWithholdVotes method no
longer exists in the code. Currently, we do reject if the candidate term is
less than current term; see
https://github.com/apache/ratis/blob/c3f78faed7bdb213b547b6edbff153e021ab6f18/ratis-server/src/main/java/org/apache/ratis/server/impl/VoteContext.java#L75-L77
> shouldWithholdVotes() should be triggered for handling higher term
> ------------------------------------------------------------------
>
> Key: RATIS-998
> URL: https://issues.apache.org/jira/browse/RATIS-998
> Project: Ratis
> Issue Type: Bug
> Components: server
> Affects Versions: 0.5.0
> Reporter: Glen Geng
> Assignee: Glen Geng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
>
> I assume that {{shouldWithholdVotes()}} is used to handle request vote
> request with higher candidate term from disruptive server, but currently it
> just ignored such requests, since it only take effect when
> {{(state.getCurrentTerm() >= candidateTerm)}} .
> shouldWithholdVotes() should be triggered for handling higher term. If
> currentTerm is larger or equal to candidateTerm, just reject the request
> vote, no need further handling.
>
> Current code is
> {code:java}
> private boolean shouldWithholdVotes(long candidateTerm) {
> if (state.getCurrentTerm() < candidateTerm) {
> return false;
> } else if (isLeader()) {
> return true;
> } else {
> // following a leader and not yet timeout
> return isFollower() && state.hasLeader()
> &&
> role.getFollowerState().map(FollowerState::shouldWithholdVotes).orElse(false);
> }
> }
> {code}
> Modify to
> {code:java}
> private boolean shouldWithholdVotes(long candidateTerm) {
> if (state.getCurrentTerm() >= candidateTerm) {
> return false;
> } else if (isLeader()) {
> return true;
> } else {
> // following a leader and not yet timeout
> return isFollower() && state.hasLeader()
> &&
> role.getFollowerState().map(FollowerState::shouldWithholdVotes).orElse(false);
> }
> }
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
