[
https://issues.apache.org/jira/browse/RATIS-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz-wo Sze resolved RATIS-660.
------------------------------
Resolution: Not A Problem
The current code will wait for all the applyTransaction futures to complete
before taking a snapshot. If a future throws an exception, it won't take a
snapshot. See
https://github.com/apache/ratis/blob/c3f78faed7bdb213b547b6edbff153e021ab6f18/ratis-server/src/main/java/org/apache/ratis/server/impl/StateMachineUpdater.java#L266-L268
So, this is no longer a problem. Resolving ...
> Ratis snapshot might miss failed applied State Machine Transactions
> --------------------------------------------------------------------
>
> Key: RATIS-660
> URL: https://issues.apache.org/jira/browse/RATIS-660
> Project: Ratis
> Issue Type: Bug
> Components: snapshot
> Affects Versions: 0.5.0
> Reporter: Shashikant Banerjee
> Priority: Major
>
> While taking a ratis snapshot, it just applied all the transactions from the
> commitIndex to the applied index. In case, it needs to take a snapshot, on
> applyTransaction failure, it closes the raftServerImpl. In case, snapshot is
> not required while applying the current set of transactions and if any of
> these transactions fail, these will be ignored. Ideally, every
> applyTransaction failures should be caught and stateMachine updater should
> not take any further snapshot once a failure is detected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
