SzyWilliam opened a new pull request, #915: URL: https://github.com/apache/ratis/pull/915
Made a mistake in previous PR https://github.com/apache/ratis/pull/904. The conditions here are bit of tricky. The cache entry is expected to be **not completed normally** when `replyPendingRequest`, since we'll complete this cache entry at the very end of `replyPendingRequest`. The explanation why this assertion fails in previous PR is incorrect. The real path leading to the error is: If the request r arrived, committed, but became timeout due to blocking apply (may be stuck in a synchronous snapshotting), a client may choose to retry r. However, if the retry gap exceeds retryCache expiration duration (in our case, yes), the very same request r will be committed, **again**. After the snapshotting finished, these two identical requests being applied will cause the assertion to fail. Maybe we should recommend users to set a retry cache expiration duration longer than the client retry-waiting duration? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
