[
https://issues.apache.org/jira/browse/RATIS-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz-wo Sze resolved RATIS-1885.
-------------------------------
Fix Version/s: 2.5.2
Resolution: Fixed
The pull request is now merged. Thanks, [~weichiu] !
> Incorrect clientWriteRequest timer usage
> ----------------------------------------
>
> Key: RATIS-1885
> URL: https://issues.apache.org/jira/browse/RATIS-1885
> Project: Ratis
> Issue Type: Bug
> Components: metrics
> Affects Versions: 2.5.1
> Reporter: Wei-Chiu Chuang
> Assignee: Wei-Chiu Chuang
> Priority: Major
> Fix For: 2.5.2
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> clientWriteRequest timer measures the time from receiving the client request
> until the leader responds back.
> But this timer is only initialized when the leader responds, so the timer is
> always close to zero.
> https://github.com/apache/ratis/blob/branch-2/ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java#L840
> The bug is accidentally fixed in 3.0.0 by RATIS-1693. But for users of 2.x
> this may still be worth fixing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
