SzyWilliam commented on code in PR #898:
URL: https://github.com/apache/ratis/pull/898#discussion_r1321059926
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/LeaderStateImpl.java:
##########
@@ -322,6 +323,9 @@ private List<FollowerInfo>
getFollowerInfos(PeerConfiguration peers) {
private final PendingStepDown pendingStepDown;
private final ReadIndexHeartbeats readIndexHeartbeats;
+ private final long leaseTimeoutMs;
+ // TODO invalidate leader lease when stepDown / transferLeader
+ private final AtomicReference<Timestamp> lease = new
AtomicReference<>(Timestamp.currentTime());
Review Comment:
Done.
##########
ratis-server/src/main/java/org/apache/ratis/server/leader/LogAppenderDefault.java:
##########
@@ -73,9 +74,10 @@ private AppendEntriesReplyProto
sendAppendEntriesWithRetries()
}
resetHeartbeatTrigger();
+ final Timestamp sendTime = Timestamp.currentTime();
getFollower().updateLastRpcSendTime(request.getEntriesCount() == 0);
final AppendEntriesReplyProto r =
getServerRpc().appendEntries(request);
- getFollower().updateLastRpcResponseTime();
+ getFollower().updateLastAppendEntriesResponseTime(sendTime);
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
