tisonkun commented on code in PR #738:
URL: https://github.com/apache/ratis/pull/738#discussion_r1326311200
##########
ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcServerProtocolService.java:
##########
@@ -197,6 +197,20 @@ public void
startLeaderElection(StartLeaderElectionRequestProto request,
}
}
+ @Override
+ public void readIndex(ReadIndexRequestProto request,
StreamObserver<ReadIndexReplyProto> responseObserver) {
+ try {
+ server.readIndexAsync(request).thenAccept(reply -> {
Review Comment:
Shall we file a JIRA ticket to fix it or just follow up RATIS-1701?
This is somehow a pattern to adapt CompletableFuture to StreamObserver
result. I'm glad to be assigned and spend some time to investigate while also
check other calls to complete StreamObserver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
