OneSizeFitsQuorum commented on PR #921: URL: https://github.com/apache/ratis/pull/921#issuecomment-1725235204
LGTM~ We've noticed previously that evicting the cache during writes consumes a significant amount of CPU resources. We're hopeful that this PR will bring about a notable performance improvement. BTW, I'm wondering if it's necessary to check the cache log threshold exceeded limit every time we appendLog? Originally, traversing the list is a lightweight CPU operation, but due to its frequent invocation, it's incurring such a high CPU overhead, even if reduced to one traversal, it can't be ignored. If the LogSegment cache is now file-grained, could we further optimize it to only check when switching RaftLog? This might result in a slight loss of precision, but it could maximize the reduction in overhead on the critical write path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
