szetszwo commented on code in PR #925:
URL: https://github.com/apache/ratis/pull/925#discussion_r1336231343
##########
ratis-server-api/src/main/java/org/apache/ratis/server/RaftServerConfigKeys.java:
##########
@@ -176,14 +176,17 @@ enum Option {
DEFAULT,
/** Use ReadIndex (see Raft Paper section 6.4). Maintains
linearizability */
- LINEARIZABLE
+ LINEARIZABLE,
+
+ /** Use Leader lease. Efficient than ReadIndex if clock drift is bounded
*/
+ LEASE
Review Comment:
Is there a good reason to use LINEARIZABLE not LEASE?
- If yes, we could have a separated configuration to enable/disable
LeaderLease.
- If not, we could just have LINEARIZABLE for ReadIndex + LeaderLease.
+1 Patch looks good other that this. Thanks @SzyWilliam for working on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
