szetszwo commented on PR #964: URL: https://github.com/apache/ratis/pull/964#issuecomment-1810747301
> ... While avoiding one internal heap copy operation, we are now facing an additional direct memory to heap copy operation. Yes, this change avoids - one copy (i.e. one heap read and one heap write) - one more heap read for crc but adds - one direct buffer read for crc > Maybe we can found a way to compute checksum directly on LogEntryProto, since it's a heap object? This is a good suggestion! Let me see if there is a way to do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
