[ 
https://issues.apache.org/jira/browse/RATIS-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Attila Doroszlai updated RATIS-1956:
------------------------------------
    Description: 
Some of the logs in {{NettyClientStreamRpc}} mention the source of the message 
using {{toString}} inherited from {{Object}}.

Examples:

{code}
[NettyClientStreamRpc-workerGroup--thread1] TRACE client.NettyClientStreamRpc 
(NettyClientStreamRpc.java:operationComplete(194)) - 
org.apache.ratis.netty.client.NettyClientStreamRpc$Connection$1@36383c10 
succeed.

[NettyClientStreamRpc-workerGroup--thread1] DEBUG client.NettyClientStreamRpc 
(NettyClientStreamRpc.java:channelRead(330)) - 
org.apache.ratis.netty.client.NettyClientStreamRpc$1@31294ad5: read 
DataStreamReplyByteBuffer:clientId=client-F61E6E1DAE37,type=STREAM_HEADER,id=1,offset=0,length=0,SUCCESS,bytesWritten=0
{code}

{{org.apache.ratis.netty.client.NettyClientStreamRpc$Connection$1@36383c10}}
{{org.apache.ratis.netty.client.NettyClientStreamRpc$1@31294ad5}}

  was:
Some of the logs in {{NettyClientStreamRpc}} mention the source of the message 
using {{toString}} inherited from {{Object}}.

Examples:

{code}
[NettyClientStreamRpc-workerGroup--thread1] TRACE client.NettyClientStreamRpc 
(NettyClientStreamRpc.java:operationComplete(194)) - 
org.apache.ratis.netty.client.NettyClientStreamRpc$Connection$1@36383c10 
succeed.

2023-12-06 21:20:26,753 [NettyClientStreamRpc-workerGroup--thread1] DEBUG 
client.NettyClientStreamRpc (NettyClientStreamRpc.java:channelRead(330)) - 
org.apache.ratis.netty.client.NettyClientStreamRpc$1@31294ad5: read 
DataStreamReplyByteBuffer:clientId=client-F61E6E1DAE37,type=STREAM_HEADER,id=1,offset=0,length=0,SUCCESS,bytesWritten=0
{code}

{{org.apache.ratis.netty.client.NettyClientStreamRpc$Connection$1@36383c10}}
{{org.apache.ratis.netty.client.NettyClientStreamRpc$1@31294ad5}}


> Avoid built-in toString in NettyClientStreamRpc log
> ---------------------------------------------------
>
>                 Key: RATIS-1956
>                 URL: https://issues.apache.org/jira/browse/RATIS-1956
>             Project: Ratis
>          Issue Type: Sub-task
>          Components: Streaming
>            Reporter: Attila Doroszlai
>            Assignee: Attila Doroszlai
>            Priority: Minor
>
> Some of the logs in {{NettyClientStreamRpc}} mention the source of the 
> message using {{toString}} inherited from {{Object}}.
> Examples:
> {code}
> [NettyClientStreamRpc-workerGroup--thread1] TRACE client.NettyClientStreamRpc 
> (NettyClientStreamRpc.java:operationComplete(194)) - 
> org.apache.ratis.netty.client.NettyClientStreamRpc$Connection$1@36383c10 
> succeed.
> [NettyClientStreamRpc-workerGroup--thread1] DEBUG client.NettyClientStreamRpc 
> (NettyClientStreamRpc.java:channelRead(330)) - 
> org.apache.ratis.netty.client.NettyClientStreamRpc$1@31294ad5: read 
> DataStreamReplyByteBuffer:clientId=client-F61E6E1DAE37,type=STREAM_HEADER,id=1,offset=0,length=0,SUCCESS,bytesWritten=0
> {code}
> {{org.apache.ratis.netty.client.NettyClientStreamRpc$Connection$1@36383c10}}
> {{org.apache.ratis.netty.client.NettyClientStreamRpc$1@31294ad5}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to