SzyWilliam commented on PR #997: URL: https://github.com/apache/ratis/pull/997#issuecomment-1866251827
> have we observed a significant drop in Ratis logs when nodes go down
since the current PR was introduced
@OneSizeFitsQuorum Yes. if we use a batch duration of 5 secs, on average 20
logs will be batched on my PC. You can refer to the screenshot
[here](https://private-user-images.githubusercontent.com/48054931/291905508-cd7bbba1-0f4f-4b9b-8d78-43ed8689bffa.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDMxNjU1NzEsIm5iZiI6MTcwMzE2NTI3MSwicGF0aCI6Ii80ODA1NDkzMS8yOTE5MDU1MDgtY2Q3YmJiYTEtMGY0Zi00YjliLThkNzgtNDNlZDg2ODliZmZhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzEyMjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMjIxVDEzMjc1MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgwNWUzOWYxYmY4N2FiNDAzYTUxYWQwMTYyYmUwMDViNTczYjhhNGZkMzVjMGY4Zjg4NmQyNDZkNjEzOGRmNmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.9LLMa_jjafAgfQXxpeJqR_8Vx1lsvthZbinTpGknfak)
> Are there other logs that print a lot？
Currently the only two log messages that print a lot are fixed in this PR.
If we observe other log messages that can be batched, it's easy to batch them
after `BatchLogger` being introduced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
