[
https://issues.apache.org/jira/browse/RATIS-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804889#comment-17804889
]
Tsz-wo Sze commented on RATIS-1646:
-----------------------------------
-
./ratis-examples/src/main/java/org/apache/ratis/examples/filestore/cli/Client.java
{code}
21: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
146: @SuppressFBWarnings("DM_EXIT")
2 occurrence(s)
{code}
-
./ratis-grpc/src/main/java/org/apache/ratis/grpc/metrics/intercept/server/MetricServerCallListener.java
{code}
21: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
26: @SuppressFBWarnings("URF_UNREAD_FIELD")
2 occurrence(s)
{code}
- ./ratis-server/src/main/java/org/apache/ratis/server/impl/PendingRequest.java
{code}
20: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
105: @SuppressFBWarnings("EQ_COMPARETO_USE_OBJECT_EQUALS")
2 occurrence(s)
{code}
-
./ratis-server/src/main/java/org/apache/ratis/server/leader/InstallSnapshotRequests.java
{code}
20: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
106: @SuppressFBWarnings("IT_NO_SUCH_ELEMENT")
2 occurrence(s)
{code}
-
./ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/BufferedWriteChannel.java
{code}
20: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
180: @SuppressFBWarnings("RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT")
2 occurrence(s)
{code}
-
./ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/LogSegment.java
{code}
20: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
402: @SuppressFBWarnings("EQ_COMPARETO_USE_OBJECT_EQUALS")
2 occurrence(s)
{code}
-
./ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/LogSegmentPath.java
{code}
20: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
61: @SuppressFBWarnings("EQ_COMPARETO_USE_OBJECT_EQUALS")
103: @SuppressFBWarnings("NP_NULL_ON_SOME_PATH")
113: @SuppressFBWarnings("NP_NULL_ON_SOME_PATH")
4 occurrence(s)
{code}
-
./ratis-server/src/main/java/org/apache/ratis/statemachine/impl/BaseStateMachine.java
{code}
21: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
200: @SuppressFBWarnings("NP_NULL_PARAM_DEREF")
2 occurrence(s)
{code}
Totally 18 occurrence(s) in 663 file(s).
> Fix suppressed Findbugs warnings
> --------------------------------
>
> Key: RATIS-1646
> URL: https://issues.apache.org/jira/browse/RATIS-1646
> Project: Ratis
> Issue Type: Bug
> Reporter: Tsz-wo Sze
> Assignee: Ethan Rose
> Priority: Major
>
> There are quite a few {{@SuppressFBWarnings}} tags in the code. We should
> fix the underlying problems or document the reason of the suppression.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
