szetszwo commented on code in PR #1006: URL: https://github.com/apache/ratis/pull/1006#discussion_r1449094545
########## ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java: ########## @@ -86,20 +65,7 @@ import org.apache.ratis.protocol.SetConfigurationRequest; import org.apache.ratis.protocol.SnapshotManagementRequest; import org.apache.ratis.protocol.TransferLeadershipRequest; -import org.apache.ratis.protocol.exceptions.GroupMismatchException; -import org.apache.ratis.protocol.exceptions.LeaderNotReadyException; -import org.apache.ratis.protocol.exceptions.LeaderSteppingDownException; -import org.apache.ratis.protocol.exceptions.NotLeaderException; -import org.apache.ratis.protocol.exceptions.RaftException; -import org.apache.ratis.protocol.exceptions.ReadException; -import org.apache.ratis.protocol.exceptions.ReadIndexException; -import org.apache.ratis.protocol.exceptions.ReconfigurationInProgressException; -import org.apache.ratis.protocol.exceptions.ResourceUnavailableException; -import org.apache.ratis.protocol.exceptions.ServerNotReadyException; -import org.apache.ratis.protocol.exceptions.SetConfigurationException; -import org.apache.ratis.protocol.exceptions.StaleReadException; -import org.apache.ratis.protocol.exceptions.StateMachineException; -import org.apache.ratis.protocol.exceptions.TransferLeadershipException; +import org.apache.ratis.protocol.exceptions.*; Review Comment: This was to [Get around RaftServerImpl.java File length is 2,019 lines (max allowed is 2,000](https://github.com/apache/ratis/pull/1006/commits/8cc04ea97b5621407814f3aab317ca148769a54f) . Filed RATIS-1996 to refactor RaftServerImpl.java Honestly, I feel people focus too much on checkstyle issues. We are better to put our attention on the code logic instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
