adoroszlai commented on PR #1016: URL: https://github.com/apache/ratis/pull/1016#issuecomment-1898780302
> Let's take this chance to move the iterator code to an inner class Thanks @szetszwo for the review. I agree that extracting to inner class improves the code. There is one piece from the review patch that I omitted: extracting the `FileChunkProto readFileChunk(FileInfo info)` method. The rest of the refactoring is straightforward, but I don't think I understand the reason `fileIndex++` can be incremented outside the `if (chunk.getDone())` block. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
