szetszwo commented on code in PR #1046:
URL: https://github.com/apache/ratis/pull/1046#discussion_r1509217381
##########
ratis-server-api/src/main/java/org/apache/ratis/server/DataStreamServerRpc.java:
##########
@@ -20,18 +20,12 @@
import org.apache.ratis.protocol.RaftPeer;
import java.io.Closeable;
-import java.net.InetSocketAddress;
/**
* A server interface handling incoming streams
* Relays those streams to other servers after persisting
*/
-public interface DataStreamServerRpc extends RaftPeer.Add, Closeable {
- /**
- * start server
- */
+public interface DataStreamServerRpc extends ServerRpc, RaftPeer.Add,
Closeable {
+ @Override
void start();
Review Comment:
You are right that we can remove it, although this signature in this one is
different -- it does not `throws IOException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
