DaveTeng0 commented on code in PR #1047: URL: https://github.com/apache/ratis/pull/1047#discussion_r1509626229
########## ratis-shell/src/main/java/org/apache/ratis/shell/cli/sh/peer/InfoCommand.java: ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.ratis.shell.cli.sh.peer; + +import org.apache.commons.cli.CommandLine; +import org.apache.commons.cli.Option; +import org.apache.commons.cli.OptionGroup; +import org.apache.commons.cli.Options; +import org.apache.ratis.client.RaftClient; +import org.apache.ratis.protocol.PeerInfoReply; +import org.apache.ratis.protocol.RaftPeerId; +import org.apache.ratis.shell.cli.RaftUtils; +import org.apache.ratis.shell.cli.sh.command.AbstractRatisCommand; +import org.apache.ratis.shell.cli.sh.command.Context; + +import java.io.IOException; + + +public class InfoCommand extends AbstractRatisCommand{ Review Comment: yeah, at first I also think it should be like that, but then I look at all the other ratis command names under package https://github.com/apache/ratis/tree/master/ratis-shell/src/main/java/org/apache/ratis/shell/cli/sh/peer are: - [AddCommand](https://github.com/apache/ratis/blob/master/ratis-shell/src/main/java/org/apache/ratis/shell/cli/sh/peer/AddCommand.java) - [RemoveCommand.java](https://github.com/apache/ratis/blob/master/ratis-shell/src/main/java/org/apache/ratis/shell/cli/sh/peer/RemoveCommand.java) - [SetPriorityCommand.java](https://github.com/apache/ratis/blob/master/ratis-shell/src/main/java/org/apache/ratis/shell/cli/sh/peer/SetPriorityCommand.java) , so I kind of just follow that naming convention.. but you're also right since I did see other command like for 'Group', they have 'group' as prefix in class name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
