DaveTeng0 commented on code in PR #1047:
URL: https://github.com/apache/ratis/pull/1047#discussion_r1516900189
##########
ratis-common/src/main/java/org/apache/ratis/protocol/GroupInfoReply.java:
##########
@@ -33,25 +34,27 @@ public class GroupInfoReply extends RaftClientReply {
private final RoleInfoProto roleInfoProto;
private final boolean isRaftStorageHealthy;
private final RaftConfigurationProto conf;
+ private LogInfoProto logInfoProto;
Review Comment:
updated!
##########
ratis-common/src/main/java/org/apache/ratis/util/ProtoUtils.java:
##########
@@ -225,10 +226,20 @@ static String toString(CommitInfoProto proto) {
return RaftPeerId.valueOf(proto.getServer().getId()) + ":c" +
proto.getCommitIndex();
}
+ static String toString(LogInfoProto proto) {
+ return "lastSnapshot: " + proto.getLastSnapshot()
+ + ", applied: " + proto.getApplied()
+ + ", committed: " + proto.getCommitted();
+ }
+
static String toString(Collection<CommitInfoProto> protos) {
return
protos.stream().map(ProtoUtils::toString).collect(Collectors.toList()).toString();
}
+ static String toStringLogInfo(Collection<LogInfoProto> protos) {
+ return
protos.stream().map(ProtoUtils::toString).collect(Collectors.toList()).toString();
+ }
+
Review Comment:
removed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
