szetszwo commented on PR #1049: URL: https://github.com/apache/ratis/pull/1049#issuecomment-1995569141
> ... Is there any reason why newAppendEntriesRequest is declared as an API under LogAppender. It seems to be more appropriate as an internal utility inside LogAppender implementations. You are right that the `newAppendEntriesRequest` and the `newInstallSnapshot[Notification]Requests` methods are better removed from the `LogAppender` interface. Let's deprecate them and remove later? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
