szetszwo commented on code in PR #1058:
URL: https://github.com/apache/ratis/pull/1058#discussion_r1539404839
##########
ratis-proto/src/main/proto/Raft.proto:
##########
@@ -470,7 +470,7 @@ message SnapshotManagementRequestProto {
}
message SnapshotCreateRequestProto {
-
+ uint64 creationGap = 1;
Review Comment:
In proto 3, `optional` is generally discouraged; see
https://cloud.google.com/apis/design/proto3
> Beginning in protobuf v3.14, primitive fields can distinguish between the
default value and unset value by using the [optional
keyword](https://cloud.google.com/apis/design/design_patterns.md#optional_primitive_fields),
although this is generally discouraged.
In our case, the default value 0 means that it will use server
configuration. So, it is compatible to the previous code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
