szetszwo commented on PR #1072:
URL: https://github.com/apache/ratis/pull/1072#issuecomment-2096290715
@ChenSammi , this JIRA is suggesting to add a callback. Instead of adding
a new callback, why not changing the `notifyServerShutdown` API and then call
it in `ImplMap.close(groupId, future)` as below?
```java
+++
b/ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerProxy.java
@@ -138,6 +138,8 @@ class RaftServerProxy implements RaftServer {
} catch (Throwable t) {
LOG.warn("{}: Failed to close the division for {}", getId(),
groupId, t);
}
+
+
impl.getStateMachine().event().notifyServerShutdown(impl.getRoleInfoProto(),
true);
}
synchronized List<RaftGroupId> getGroupIds() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
