[
https://issues.apache.org/jira/browse/RATIS-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845035#comment-17845035
]
Tsz-wo Sze edited comment on RATIS-2081 at 5/9/24 3:45 PM:
-----------------------------------------------------------
[~Symious], thanks for reporting this. We have decided not to enable checkstyle
in test source; see RATIS-1069. The reason is that checkstyle is just catching
code style issues which is unimportant in tests. Sorry that I should have
comment on this JIRA earlier.
I saw that you already had a pull request. It is good to fix the existing
problem even if checkstyle is disabled. I suggest that we fix some of the
problems such as renaming the static final variables to upper cases, removing
unused imports, etc. However, the @SuppressWarnings tags are not needed since
they did not really fix anything.
The change is very big. For easier to review, we may fix it in two steps
# fix only renaming the static final variables to upper cases and removing
unused imports.
# fix other things.
We may also add a comment in pom.xml saying that we have decided not to enable
checkstyle in tests.
was (Author: szetszwo):
[~Symious], thanks for reporting this. We have decided not to enable checkstyle
in test source; see RATIS-1069. The reason is that checkstyle is just catch
code style issues which is unimportant in tests. Sorry that I should have
comment on this JIRA earlier.
I saw that you already had a pull request. It is good to fix the existing
problem even if checkstyle is disabled. I suggest that we fix some of the
problems such as renaming the static final variables to upper cases, removing
unused imports, etc. However, the @SuppressWarnings tags are not needed since
they did not really fix anything.
The change is very big. For easier to review, we may fix it in two steps
# fix only renaming the static final variables to upper cases and removing
unused imports.
# fix other things.
We may also add a comment in pom.xml saying that we have decided not to enable
checkstyle in tests.
> Checkstyle not including test source directory
> ----------------------------------------------
>
> Key: RATIS-2081
> URL: https://issues.apache.org/jira/browse/RATIS-2081
> Project: Ratis
> Issue Type: Improvement
> Components: test
> Reporter: Janus Chow
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Checkstyle is not checking test source directory. This ticket is to resolve
> this issue.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
