szetszwo commented on code in PR #1091:
URL: https://github.com/apache/ratis/pull/1091#discussion_r1598859686
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/ConfigurationManager.java:
##########
@@ -61,10 +61,10 @@ private void setCurrentConf(RaftConfigurationImpl
currentConf) {
}
}
- synchronized void addConfiguration(RaftConfiguration conf) {
+ synchronized void addConfiguration(RaftConfiguration conf, long commitIndex)
{
final long logIndex = conf.getLogEntryIndex();
final RaftConfiguration found = configurations.get(logIndex);
- if (found != null) {
+ if (found != null && logIndex <= commitIndex) {
Review Comment:
Why changing this? We should not allow two confs with the same index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
