szetszwo commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1613122613
##########
ratis-shell/pom.xml:
##########
@@ -48,6 +48,14 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-simple</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.ratis</groupId>
+ <artifactId>ratis-grpc</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.ratis</groupId>
+ <artifactId>ratis-netty</artifactId>
+ </dependency>
Review Comment:
@DaveTeng0 , Thanks a lot for working on this! This refactoring change
should not add new dependencies. I understand that the new dependencies is for
supporting security. Please make the security in a separated JIRE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
