szetszwo commented on PR #1108:
URL: https://github.com/apache/ratis/pull/1108#issuecomment-2148105196
Even I have commented out `setZeroCopyEnabled(properties, true)`
```java
diff --git
a/ratis-grpc/src/test/java/org/apache/ratis/grpc/MiniRaftClusterWithGrpc.java
b/ratis-grpc/src/test/java/org/apache/ratis/grpc/MiniRaftClusterWithGrpc.java
index bd3b137501..5c57854759 100644
---
a/ratis-grpc/src/test/java/org/apache/ratis/grpc/MiniRaftClusterWithGrpc.java
+++
b/ratis-grpc/src/test/java/org/apache/ratis/grpc/MiniRaftClusterWithGrpc.java
@@ -77,7 +77,7 @@ public class MiniRaftClusterWithGrpc extends
MiniRaftCluster.RpcBase {
Optional.ofNullable(getAddress(id, group,
RaftPeer::getAdminAddress)).ifPresent(address ->
GrpcConfigKeys.Admin.setPort(properties,
NetUtils.createSocketAddr(address).getPort()));
// Always run grpc integration tests with zero-copy enabled because the
path of nonzero-copy is not risky.
- GrpcConfigKeys.Server.setZeroCopyEnabled(properties, true);
+// GrpcConfigKeys.Server.setZeroCopyEnabled(properties, true);
return parameters;
}
diff --git
a/ratis-server/src/test/java/org/apache/ratis/InstallSnapshotFromLeaderTests.java
b/ratis-server/src/test/java/org/apache/ratis/InstallSnapshotFromLeaderTests.java
index b83a7dfdd3..e83a40e89b 100644
---
a/ratis-server/src/test/java/org/apache/ratis/InstallSnapshotFromLeaderTests.java
+++
b/ratis-server/src/test/java/org/apache/ratis/InstallSnapshotFromLeaderTests.java
@@ -95,7 +95,6 @@ public abstract class
InstallSnapshotFromLeaderTests<CLUSTER extends MiniRaftClu
}
private void testMultiFileInstallSnapshot(CLUSTER cluster) throws
Exception {
- try {
int i = 0;
RaftTestUtil.waitForLeader(cluster);
final RaftPeerId leaderId = cluster.getLeader().getId();
@@ -131,13 +130,9 @@ public abstract class
InstallSnapshotFromLeaderTests<CLUSTER extends MiniRaftClu
Assertions.assertEquals(3, info.getFiles().size());
}
}, 10, ONE_SECOND, "check snapshot", LOG);
- } finally {
- cluster.shutdown();
- }
}
private void testInstallSnapshotDuringLeaderSwitch(CLUSTER cluster)
throws Exception {
- try {
RaftTestUtil.waitForLeader(cluster);
final RaftPeerId leaderId = cluster.getLeader().getId();
@@ -192,9 +187,6 @@ public abstract class
InstallSnapshotFromLeaderTests<CLUSTER extends MiniRaftClu
reply = client.io().send(new
RaftTestUtil.SimpleMessage("final"));
Assertions.assertTrue(reply.isSuccess());
}
- } finally {
- cluster.shutdown();
- }
}
private static class StateMachineWithMultiNestedSnapshotFile extends
SimpleStateMachine4Testing {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
