adoroszlai opened a new pull request, #52:
URL: https://github.com/apache/ratis-thirdparty/pull/52
## What changes were proposed in this pull request?
- Bump `maven-shade-plugin` to fix:
```
$ mvn artifact:check-buildplan
...
[ERROR] plugin with non-reproducible output:
org.apache.maven.plugins:maven-shade-plugin:3.1.1, require minimum 3.5.2
```
- Enable reproducible builds by adding `project.build.outputTimestamp`
property.
- Add new step in CI to verify that build is reproducible.
https://issues.apache.org/jira/browse/RATIS-2119
## How was this patch tested?
Same steps as in CI.
```
$ mvn --no-transfer-progress -Ptest -Prelease clean install
...
$ mvn --no-transfer-progress -Ptest -Prelease -DskipTests clean verify
artifact:compare
...
[INFO] --- maven-artifact-plugin:3.5.1:compare (default-cli) @
ratis-thirdparty ---
...
[INFO] Reproducible Build output summary: 3 files ok
...
[INFO] --- maven-artifact-plugin:3.5.1:compare (default-cli) @
ratis-thirdparty-misc ---
...
[INFO] Reproducible Build output summary: 6 files ok
...
[INFO] --- maven-artifact-plugin:3.5.1:compare (default-cli) @
ratis-thirdparty-test ---
...
[INFO] Reproducible Build output summary: 15 files ok
```
CI:
https://github.com/adoroszlai/ratis-thirdparty/actions/runs/9666704190/job/26666824465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
