[
https://issues.apache.org/jira/browse/RATIS-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duong updated RATIS-2132:
-------------------------
Description:
This commit creates a significant extra cost in the critical path (which is run
sequentially) of Ratis appendTransaction.
!Screenshot 2024-07-29 at 5.07.32 PM.png|width=981,height=479!
This seems to be a premature optimization. One or two instances of TermIndex
per request are basically nothing (unless we create hundreds/thousands of them
per request). Short-lived POJO like this are the best to be dealt with by
java GC/heap.
More details are the parent Jira RATIS-2129.
was:
This commit creates a significant extra cost in the critical path (which is run
sequentially) of Ratis appendTransaction.
!Screenshot 2024-07-29 at 5.07.32 PM.png|width=981,height=479!
This seems to be a premature optimization. One or two instance of TermIndex per
request is nothing in comparison to the memory spent on protobuf. Plust
GC/Java runtime itself has its on internal optimization of this kind of small
object
More details are the parent Jira RATIS-2129.
> Revert RATIS-2099 due to its performance regression
> ---------------------------------------------------
>
> Key: RATIS-2132
> URL: https://issues.apache.org/jira/browse/RATIS-2132
> Project: Ratis
> Issue Type: Sub-task
> Reporter: Duong
> Assignee: Duong
> Priority: Major
> Attachments: Screenshot 2024-07-29 at 5.07.32 PM.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This commit creates a significant extra cost in the critical path (which is
> run sequentially) of Ratis appendTransaction.
> !Screenshot 2024-07-29 at 5.07.32 PM.png|width=981,height=479!
> This seems to be a premature optimization. One or two instances of TermIndex
> per request are basically nothing (unless we create hundreds/thousands of
> them per request). Short-lived POJO like this are the best to be dealt with
> by java GC/heap.
> More details are the parent Jira RATIS-2129.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
