chungen0126 commented on code in PR #1130:
URL: https://github.com/apache/ratis/pull/1130#discussion_r1704857284
##########
ratis-server/src/main/java/org/apache/ratis/server/raftlog/RaftLogBase.java:
##########
@@ -242,25 +245,11 @@ private boolean shouldAppendMetadata(long newCommitIndex)
{
// do not log the first conf entry
return false;
} else if (Optional.ofNullable(lastMetadataEntry.get())
- .filter(e -> e.getIndex() == newCommitIndex ||
e.getMetadataEntry().getCommitIndex() >= newCommitIndex)
+ .filter(e -> e.getMetadataEntry().getCommitIndex() >= newCommitIndex)
.isPresent()) {
- //log neither lastMetadataEntry, nor entries with a smaller commit index.
+ // do not log entries with a smaller commit index.
return false;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
