OneSizeFitsQuorum commented on PR #1127:
URL: https://github.com/apache/ratis/pull/1127#issuecomment-2296409630

   Hi, @szetszwo 
   We have tested this pull request,  the write throughput is improved by about 
25%.
   
   Before:
   
![image](https://github.com/user-attachments/assets/a4ef9f67-d7fe-4686-bd01-4969a8a03fae)
   After:
   
![image](https://github.com/user-attachments/assets/9cdf21d2-9777-4403-88bf-d8c2e63d87d5)
   
   We analyzed the flame graph and found that 15% of the Raftlog read locks had 
disappeared, which made acquiring raftlog locks faster in the write path, 
resulting in better write performance.This indicates that the write throughput 
improvement from this PR is still substantial.
   
   <img width="1511" alt="image" 
src="https://github.com/user-attachments/assets/ff960461-b1d9-4d01-857c-2c5eacb98cf6";>
   <img width="1511" alt="image" 
src="https://github.com/user-attachments/assets/78b33fa2-cf3d-464c-8458-96fc08894695";>
   
   In addition, we found that UpdateCommitIndex also takes a lot of CPU in the 
latest optimized scenario. It should be beneficial to continue to optimize the 
locking logic here.
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to