133tosakarin commented on code in PR #1142:
URL: https://github.com/apache/ratis/pull/1142#discussion_r1742478680
##########
ratis-server/src/main/java/org/apache/ratis/server/storage/SnapshotManager.java:
##########
@@ -114,7 +115,8 @@ public void installSnapshot(InstallSnapshotRequestProto
request, StateMachine st
// TODO: Make sure that subsequent requests for the same installSnapshot
are coming in order,
// and are not lost when whole request cycle is done. Check requestId and
requestIndex here
-
+ MessageDigest digester = newMd5Digest();
+ digester.reset();
Review Comment:
Yes, ThreadLocal variables should be safe. However, we have stably
reproduced this issue in multiple different testing environments, and we are
also identifying whether there is a problem with the JDK version we are using.
During this process, we have made an important discovery that even if we
receive an empty file, Corrupt will still appear.
<img width="805" alt="image"
src="https://github.com/user-attachments/assets/7cacaa35-68cd-4510-a50d-5caf35296164";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
